fix: focus hidden for c-feed-list "read more" link#609
Merged
wesleyboar merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Mar 26, 2026
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Mar 30, 2026
* feat: auto- title "Supersized Science" podcasts * fix: google search bugs (#538) * fix: duplicate underline for search result titles on hover Added a rule to remove duplicate underline on hover for search result titles. * fix: undo Core-Styles link style in search suggestions Add styles to override core-styles for links in Google search suggestions. * fix: set color for Google magnifier icon * fix: google accent color on highlighted term Use TACC accent color not Google accent color on highlighted term. * fix: accent color contrast vs normal text (CMS) * fix: accent color contrast vs normal text (Portal) * fix: invisible hover state on footer social logos (#539) The gray background matched parent background, so not visible. So, I fix it by making color darker. * chore: delete inaccurate, unrealized code - Should be style-dark and style-dark, not style-dark and style-light. - This code affects color that is already inherited as the same result. * fix: darker nav text * fix: explain "Update" pill (and remove extra span) * fix(a11y): nav dropdown icons unexplained to aria * fix: aria-label="…" when data-prefix="Published:" * chore: format markup for "Update" pill * fix: improve focus UI clarity (kill old code) This code is outdated. What it used to do is now done better by default styles. Retaining it causes less visual focus clarity. * fix: save use of previous commit on snippet Previous commit changes CSS. This comit saves our update live to use that new CSS via CDN. * fix(a11y): relate SoftwareTable button & dialog * fix: login; required fail, autocomplete wrong * chore: npx nx format:write * fix: require input on software list search * Revert "fix: require input on software list search" This reverts commit 22dfb64. * enhance: software table accessibility * deps: core-cms#fix/a11y-issues * refactor: djangocms-blog settings This is the new way to do it. TUP CMS is the only client using old way. * refactor: DJANGOCMS_ICON_SETS settings load path These settings were moved in TACC/Core-CMS#v4.35.10 * fix: missing comma * test: fix failing test https://github.com/TACC/tup-ui/actions/runs/22872540854/job/66355765575?pr=537 * chore: npx nx format:write * deps: update Core-CMS from v37 to v38 * fix: login page missing styles * feat: special title for Supersized science podcast * fix: CSS expects portal <html> ID as page-portal https://github.com/search?q=repo%3ATACC%2Ftup-ui%20%22%23page-portal%22&type=code The `page-` was forced in TACC/Core-CMS#v4.28 but not since TACC/Core-CMS#v4.29 https://github.com/TACC/Core-CMS/blob/v4.28.0/taccsite_cms/templates/base.html#L5 https://github.com/TACC/Core-CMS/blob/v4.29.0/taccsite_cms/templates/base.html * fix: CSS expects portal <html> ID as page-portal https://github.com/search?q=repo%3ATACC%2Ftup-ui%20%22%23page-portal%22&type=code The `page-` was forced in TACC/Core-CMS#v4.28 but not since TACC/Core-CMS#v4.29 https://github.com/TACC/Core-CMS/blob/v4.28.0/taccsite_cms/templates/base.html#L5 https://github.com/TACC/Core-CMS/blob/v4.29.0/taccsite_cms/templates/base.html * deps: Core-CMS v4.38.4 (unreleased) * fix: podcast has excess vertical space * fix: default video player not overwritten yet * chore: link for podcast vertical space * fix: nav icon wrong color * debug: portal nav logged in state not shown It works right on main branch… so, what happenned? Let's log a bit! * Revert "debug: portal nav logged in state not shown" This reverts commit 683633e. * fix: portal nav not showing logged in state Requires TACC/Core-CMS#1117 * Revert "fix: portal nav not showing logged in state" This reverts commit 2334cfc. * fix: accent color contrast vs normal text (Portal) 2 Continues 554d136. * Revert "fix: accent color contrast vs normal text (Portal) 2" This reverts commit add55ed. incorrrect change. Edited code seems unused. * fix: should use Core-Styles#fix/a11y-issues …until it is released, then use new release. * fix: complete suite of link state UX for Navbar * fix(a11y): accent blue for links on dark section * fix: ci error * chore: delete outdated new window js Has not been used for a while in favor of Core-CMS. Outdated since TACC/Core-CMS@89355dd6, in which COre-CMS brings over improvements this script had. * fix: remove unnecessary aria-label, improve text * fix: remove another unnecessary aria-label Keep aria-label like this only if "Published" is not in text e.g. ``` data-prefix="Published:" ``` * fix: Update needds "d" (last remaining instance) * feat: add `link_name` to PORTAL_LOGO setting * fix(a11y): parent Name reads `i.icon` as odd char Parent element reads <i class="icon…">` as a an odd character. Using `aria-hidden` isntead of `role` fixes that. * fix(a11y): describe logged in user * fix: update footer since new logo CSS & HTML * refactor: logged in dropodown as button not link * fix: inaccessible footer social logos colors * fix: link contrast in footer * fix(a11y): footer logo hover/active UX * deps: @tacc/core-styles v2.54.0-rc1 * chore: delete redundant styles * deps: core-cms v4.39, core-styles v2.54 * fix: bad end tag → button has ineffectual links The wrong end tag cause button to wrap menu with links. Those links, because inside a button, were ineffectual. * fix: buttons inside links * fix: finish fixing link-button combos * refactor: <Button> to use 'as' prop for links * Revert "refactor: <Button> to use 'as' prop for links" This reverts commit 49bcbf5. * Revert "fix: finish fixing link-button combos" This reverts commit bfee804. * Revert "fix: buttons inside links" This reverts commit 97b284f. * fix: focus hidden for c-feed-list "read more" link mirrors TACC/Core-Styles#609 * deps: Core-CMS `…core-styles-for-more-a11y-fixes` * fix: core-CMS figcaption opacity affecting banners * fix(a11y): final issues* & core-styles v2.54.1 * (that I have bandwidth to fix and/or are important) * deps: core-cms v4.39.1 (release of previous build) --------- Co-authored-by: Jake Rosenberg <jrosenberg@tacc.utexas.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Feed list should not hide overflow, because:
if editor makes it too long1
Related
Changes
Testing & UI
no.overflow.allows.full.focus.mov
Footnotes
A pattern library's CSS is to style, not to stop ridiculous text content from being used. ↩