fix(footer): darken footer text#633
Merged
Merged
Conversation
Use the next darker primary token for footer foreground text so footer content and links match the restored v2 contrast baseline. Made-with: Cursor
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoDarken footer text color one token step
WalkthroughsDescription• Change footer text color from --global-color-primary--x-light to --global-color-primary--light • Darkens footer foreground text by one token step for improved contrast • Restores v2 contrast baseline for footer content and links • Updates both source and compiled CSS files Diagramflowchart LR
A["Footer Color Token"] -->|"Change from x-light"| B["--global-color-primary--light"]
B -->|"Improves contrast"| C["Better readability"]
C -->|"Matches v2 baseline"| D["Restored contrast"]
File Changes1. src/lib/_imports/trumps/s-footer.css
|
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try againⓘ The new review experience is currently in Beta. Learn more |
Rebuild generated CMS/portal bundles from source after footer token change and add agent instructions to avoid manual edits in dist output. Made-with: Cursor
Keep footer color PR focused on style output by removing AGENTS guidance from this branch. Made-with: Cursor
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Apr 17, 2026
## Overview Use a Core-Styles commit-ish with the footer text-color fix. ## Related - requires TACC/Core-Styles#633 ## Changes - **updated** `@tacc/core-styles` to a branch-based install - **updated** lockfile entries to the matching Core-Styles commit ## Testing 1. Verify dependency and lockfile both reference `fix/footer-text-color-one-step-darker`. 2. Build CSS locally and confirm footer text/links render one step darker. ## UI <img width="960" height="874" alt="cms-footer-after" src="https://github.com/user-attachments/assets/48b850ce-7f0e-43f2-be2c-ded2452113fc" /> --- Made with [Cursor](https://cursor.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Darken
s-footerforeground color by one token step.Changes
Testing
s-footeruses--global-color-primary--light.UI
Made with Cursor