fix(footer): normalize footer link color-mix syntax#635
Merged
Conversation
Use explicit `in srgb` color-mix syntax for footer link decoration so computed styles are consistent across browser contexts. Made-with: Cursor
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoNormalize footer link color-mix syntax with srgb color space
WalkthroughsDescription• Normalize footer link color-mix() syntax with explicit in srgb color space • Ensures consistent computed styles across browser contexts • Updates source and compiled CSS distribution files Diagramflowchart LR
A["Footer link decoration<br/>color-mix syntax"] -->|"Add explicit<br/>in srgb"| B["Normalized<br/>color-mix declaration"]
B -->|"Rebuild"| C["Updated dist<br/>bundles"]
C -->|"Result"| D["Consistent browser<br/>rendering"]
File Changes1. src/lib/_imports/trumps/s-footer.css
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Normalize footer link underline color syntax for consistent parsing.
Changes
s-footerlink mixin to usecolor-mix(in srgb, ...)distbundles from a full CSS rebuildTesting
s-footer--cmsdemo and verify footer linktext-decoration-colorcomes fromcore-styles.cms.css.color-mix(...)declaration.UI
Made with Cursor