Skip to content

fix(footer): normalize footer link color-mix syntax#635

Merged
wesleyboar merged 1 commit into
mainfrom
fix/footer-colormix-srgb-syntax
Apr 17, 2026
Merged

fix(footer): normalize footer link color-mix syntax#635
wesleyboar merged 1 commit into
mainfrom
fix/footer-colormix-srgb-syntax

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Apr 17, 2026

Overview

Normalize footer link underline color syntax for consistent parsing.

Changes

  • updated s-footer link mixin to use color-mix(in srgb, ...)
  • updated generated dist bundles from a full CSS rebuild

Testing

  1. Open s-footer--cms demo and verify footer link text-decoration-color comes from core-styles.cms.css.
  2. Confirm no strike-through parser warning on the color-mix(...) declaration.

UI

Before After
before after

Made with Cursor

Use explicit `in srgb` color-mix syntax for footer link decoration so computed styles are consistent across browser contexts.

Made-with: Cursor
@qodo-code-review
Copy link
Copy Markdown

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Normalize footer link color-mix syntax with srgb color space

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Normalize footer link color-mix() syntax with explicit in srgb color space
• Ensures consistent computed styles across browser contexts
• Updates source and compiled CSS distribution files
Diagram
flowchart LR
  A["Footer link decoration<br/>color-mix syntax"] -->|"Add explicit<br/>in srgb"| B["Normalized<br/>color-mix declaration"]
  B -->|"Rebuild"| C["Updated dist<br/>bundles"]
  C -->|"Result"| D["Consistent browser<br/>rendering"]
Loading

Grey Divider

File Changes

1. src/lib/_imports/trumps/s-footer.css 🐞 Bug fix +1/-1

Add explicit srgb color space to color-mix

• Updated text-decoration-color property to use explicit color-mix(in srgb, ...) syntax
• Applied change to both footer link and footer identity link selectors
• Ensures consistent color space specification for cross-browser compatibility

src/lib/_imports/trumps/s-footer.css


2. dist/trumps/s-footer.css ⚙️ Configuration changes +1/-1

Rebuild footer CSS with srgb syntax

• Regenerated minified CSS with updated color-mix(in srgb, ...) syntax
• Updated two instances of footer link decoration color declarations
• Reflects source file changes in compiled distribution bundle

dist/trumps/s-footer.css


3. dist/core-styles.cms.css ⚙️ Configuration changes +1/-1

Rebuild CMS distribution bundle

• Regenerated compiled CSS bundle from full rebuild
• Includes updated footer link color-mix syntax with explicit srgb color space

dist/core-styles.cms.css


View more (1)
4. dist/core-styles.portal.css ⚙️ Configuration changes +1/-1

Rebuild portal distribution bundle

• Regenerated compiled CSS bundle from full rebuild
• Includes updated footer link color-mix syntax with explicit srgb color space

dist/core-styles.portal.css


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Apr 17, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@wesleyboar wesleyboar merged commit 377af65 into main Apr 17, 2026
@wesleyboar wesleyboar deleted the fix/footer-colormix-srgb-syntax branch April 17, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant