refactor: use TALXIS.Platform.Metadata.Packaging library for solution pack/unpack#80
Open
metjuperry wants to merge 2 commits into
Open
refactor: use TALXIS.Platform.Metadata.Packaging library for solution pack/unpack#80metjuperry wants to merge 2 commits into
metjuperry wants to merge 2 commits into
Conversation
… pack/unpack Replace the inline SolutionPackagerLib workaround with a reference to the new TALXIS.Platform.Metadata.Packaging NuGet package. Changes: - Remove ISolutionPackagerService from TALXIS.CLI.Core (now in library) - Remove SolutionPackagerServiceImpl from Dataverse.Application - Remove Microsoft.PowerApps.CLI.Core.linux-x64 workaround from csproj - Add TALXIS.Platform.Metadata.Packaging PackageReference - Update DI registration and using statements Depends on: TALXIS/platform-metadata#48 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Changed TALXIS.Platform.Metadata.Packaging version from 1.0.0 to 0.4.0 to match other TALXIS.Platform.Metadata packages - Restored 'using TALXIS.CLI.Platform.Dataverse.Application.Sdk' in DataverseSolutionExportService.cs — SolutionExporter still lives there Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the inline
SolutionPackagerLibworkaround with a reference to the new TALXIS.Platform.Metadata.Packaging NuGet package.Depends on
TALXIS.Platform.Metadata.Packagingproject)Changes
ISolutionPackagerServicefromTALXIS.CLI.Core/Contracts/Dataverse/— now provided by the librarySolutionPackagerServiceImplfromSdk/— implementation now lives in the libraryMicrosoft.PowerApps.CLI.Core.linux-x64NuGet workaround fromTALXIS.CLI.Platform.Dataverse.Application.csprojTALXIS.Platform.Metadata.PackagingPackageReference toTALXIS.CLI.Platform.Dataverse.ApplicationandTALXIS.CLI.Features.EnvironmentSolutionPackagerServicefrom the libraryusingstatements in all consuming filesNotes
TALXIS.Platform.Metadata.Packagingv1.0.0 NuGet package is published from TALXIS/platform-metadata#48. The version reference may need adjustment once the package is published.