Sprint 5 staging #103
Merged
Sprint 5 staging #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the verbage for checkboxes in add and edit service admin forms.
…URL provided The service URL is only conditionally added, so it is safe to add required to the input field without adding any further checks. This automatically causes the Create/Update button to become disabled when the URL text field is empty.
…ub.com/TAMULib/LibraryServiceStatusSystemUI into sprint5-b03523-downed-serviced-visible
…oat to the top even if not shortlisted so I can notice them Pull maintenance entirely out of the array before reducing out the short list. Then append the short list array to the newly constructed maintenance array.
Add failsafe as public view if user role is undefined. Weaver-UI-Core currently does not define "role" if the user is anonymous. Non-public accounts may not have the role property assigned. If the role is undefined, assume user is anonymous. There is a setting 'anonymousRole' in app/config/appConfig.js. I cannot find anywhere this is being used. Ideally, this would need to respect the 'anonymousRole' appConfig.js setting but the solution may need to be done in Weaver-UI-Core instead of here. This maintains the existing check for ROLE_ANONYMOUS such that if and when Weaver-UI-Core makes the mentioned change, this file need not be altered.
…status for a user
…UserRepo) mockUserRepo is returning an undefined variable.
…ective-sorting-services-improvements suggested improvements
…sible Altered filter to promote downed services to the short list
…biage Item B-03522: Change service verbiage
…ing-and-url-columns Removed Url column and merged it into Auto Updating column
…oblem-to-help Item B-03524: Change "Report a Problem" button to "Help"
…re_url Defect: D-01185 save/update possible when Service set to auto but no …
Added title to status icons for hover text
…at_to_top Item B-03530: As a Patron, I would like In-Maintenance Services to fl…
…_for_anonymous Defect D-01186: Non-Public Services showing for anonymous user
…and-order Reordered tabs and altered permissions
…ective-sorting-services
…ective-sorting-services
…ective-sorting-services Sprint5 b03526 isolated scope directive sorting services
Recreated from: 8b39951
…re change Solving B-03526 changed the structure of the table, effectively breaking B-03525's solution. Solve B-03525 with consideration to B-03526's new structure. Use "Auto Updating URL" instead of either "Auto Updating" or "URL" for clarity.
Sprint5 b03526 b03525 conflict
The solution for B-03523 incorrectly tests when the status is set to "DOWN". It appears to be testings if the service is visible to the public OR if the status is "DOWN". This ends up exposing non-public services to anonymous, thereby re-introducing D-01186. Change the filterByStatus() condition parameter to an array so that multiple status can be checked via a single pass.
Fix regression in D-01186, introduced by B-03523
ghost
requested a review
from 
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
jcreel
approved these changes
Jul 25, 2018
Member
jcreel
left a comment
jcreel
left a comment
There was a problem hiding this comment.
Approved features from sprint 5. Improved test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.