added pinch zoom to QR code scanner#549
Conversation
There was a problem hiding this comment.
Very good implementation! Though, while it does zoom, the scale change isn't that drastic on my device. I use a Pixel 6a. This could be solved by simply giving more weight to the zoom (eg. zoom={zoom * 5}).
If the scale is much greater on iOS, then we might need to do a little more testing with other devices (we can do that during the next meeting). Also, don't worry about the unit tests; Jason is in the middle of fixing them.
There was a problem hiding this comment.
I modified the code on android to use event.scale without velocity and it seems to work pretty well. I would do some testing to see if it's possible to use this implementation on iOS too since it's much simpler (or if I broke anything on iOS), but otherwise this appears good to go.
|
IOS overall is good. I tested it more and noticed that pinch in/out is a bit off. But trying to go for absolute perfection might be a waste of time. |
3 participants
Added pinch zoom to QR code scanning screen
Added circular button for displaying and resetting zoom