Skip to content

Point calculation fix#568

Merged
LucientZ merged 2 commits into
devfrom
point-calculation-fix
Nov 8, 2024
Merged

Point calculation fix#568
LucientZ merged 2 commits into
devfrom
point-calculation-fix

Conversation

@LucientZ
Copy link
Copy Markdown
Collaborator

@LucientZ LucientZ commented Oct 30, 2024

Minor bug fix:

  • Removed accidental side-effect of modifying the passed in log object for calculateEventLogPoints
  • Changed log text to be "signed out" for eventSignOut
  • All events are now support pointsPerHour
    • Even if this isn't really going to be used. It just makes the code more predictable

This is not related to any issue. It's just some tweaks I noticed needed to be made.

@LucientZ LucientZ added the bug Something isn't working label Oct 30, 2024
@LucientZ LucientZ self-assigned this Oct 30, 2024
mestrada03
mestrada03 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mestrada03 mestrada03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LucientZ LucientZ merged commit 0722a88 into dev Nov 8, 2024
@LucientZ LucientZ deleted the point-calculation-fix branch December 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mestrada03 mestrada03 mestrada03 approved these changes

Assignees

@LucientZ LucientZ

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LucientZ @mestrada03