Removed caching for members on membership page#599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The app has grown to a point where caching aggregate queries in
localStorageis not feasable due to the limits on storage space. This should never have been a thing in the first place as localStorage is meant to be small and shouldn't be used at scale.This has caused issues where the user is not able to see certain data like MemberSHPE requests because the cache errors out before the data is even able to be fetched since no more data can even be stored in the first place. This hotfix fixes this temporarily until a better fix can be implemented.
This also adds heads and bodies to certain tables to keep up with the HTML spec.