[cmake] namespace test/example/demo targets #35
Merged
Conversation
… namespace with overly generic names like "demo"
janbrandejs
reviewed
Feb 6, 2026
Contributor
There was a problem hiding this comment.
looks great, we just need to enable BUILD_TESTING by default. Without at least on thing to run for newcomers by default the reference implementation is not very accessible.
That's why I believe we had demo on by default
EDIT:
I see this is a ON by default as defined by CMAKE once one does include(CTest). So it's all ok
https://stackoverflow.com/questions/41832908/set-build-testing-to-off-by-default-using-ctest
janbrandejs
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid polluting global namespace with overly generic names like
demo