Skip to content

Fix video filename with ffmpeg writer#4512

Merged
vadosnaprimer merged 1 commit intoTASEmulators:masterfrom
SuuperW:av_filename
Nov 7, 2025
Merged

Fix video filename with ffmpeg writer#4512
vadosnaprimer merged 1 commit intoTASEmulators:masterfrom
SuuperW:av_filename

Conversation

@SuuperW
Copy link
Copy Markdown
Contributor

@SuuperW SuuperW commented Oct 18, 2025

Issue fixed:

  1. Set window size to 2x.
  2. Enable A/V capture OSD
  3. Record video with ffmpeg writer, give the name "test.mp4"
  4. Frame advance to actually capture a frame
    Result: The video is written to "test_1.mp4". File "test.mp4" was created but has no video.

This PR fixes the issue by pulling out the logic for acquiring a IVideoProvider that was being used in MainForm.AvFrameAdvance to its own method, and using that method to obtain the initial video resolution.

Check if completed:

@vadosnaprimer vadosnaprimer changed the title Fix video filename Fix video filename with ffmpeg writer Oct 18, 2025
@YoshiRulz YoshiRulz added the App: EmuHawk Relating to EmuHawk frontend label Oct 18, 2025
Copy link
Copy Markdown
Contributor

@nattthebear nattthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could never follow the mainform shenanigans for frame advance event ordering and similar stuff very well.

This seems reasonable.

Comment thread src/BizHawk.Client.EmuHawk/MainForm.cs Outdated
Comment thread src/BizHawk.Client.EmuHawk/MainForm.cs Outdated
@vadosnaprimer vadosnaprimer merged commit 1b07297 into TASEmulators:master Nov 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App: EmuHawk Relating to EmuHawk frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants