Add analog keybinds for Ares64

[rjgabel]

Fixes #3871.

Check if completed:

• I have run any relevant test suites
• I, the commit author, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

[YoshiRulz]

Compare the implementation for Mupen:

BizHawk/src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64Input.cs

Lines 37 to 87 in 3e6951d

	private const sbyte _maxAnalogX = 127;
	private const sbyte _minAnalogX = -128;
	private const sbyte _maxAnalogY = 127;
	private const sbyte _minAnalogY = -128;
	/// <summary>
	/// Translates controller input from EmuHawk into
	/// N64 controller data
	/// </summary>
	/// <param name="i">Id of controller to update and shove</param>
	public int GetControllerInput(int i)
	{
	_emuCore.InputCallbacks.Call();
	ThisFrameInputPolled = true;
	// Analog stick right = +X
	// Analog stick up = +Y
	string p = "P" + (i + 1);
	sbyte x;
	if (Controller.IsPressed(p + " A Left"))
	{
	x = _minAnalogX;
	}
	else if (Controller.IsPressed(p + " A Right"))
	{
	x = _maxAnalogX;
	}
	else
	{
	x = (sbyte)Controller.AxisValue(p + " X Axis");
	}
	sbyte y;
	if (Controller.IsPressed(p + " A Up"))
	{
	y = _maxAnalogY;
	}
	else if (Controller.IsPressed(p + " A Down"))
	{
	y = _minAnalogY;
	}
	else
	{
	y = (sbyte)Controller.AxisValue(p + " Y Axis");
	}
	int value = ReadController(i + 1);
	value |= (x & 0xFF) << 16;
	value |= (y & 0xFF) << 24;
	return value;
	}

I think it would be better as a static helper method which was shared by both cores.

[CasualPokePlayer]

Not including this was an explicit choice. This thing is a hack and shouldn't be done within the core, it should be done within the frontend for all analog controls, without the core knowing.

[rjgabel]

Not including this was an explicit choice. This thing is a hack and shouldn't be done within the core, it should be done within the frontend for all analog controls, without the core knowing.

I definitely agree that, longer term, this should probably be done by allowing button/key inputs for analog axes, but from what I can tell that seems like it would be a fairly large rewrite that doesn't seem like it's happening soon. And considering we already have the hack present in the Mupen core, I think it makes sense to include it as a stopgap in Ares64 as well.

[rjgabel]

Compare the implementation for Mupen:

BizHawk/src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64Input.cs

Lines 37 to 87 in 3e6951d

	private const sbyte _maxAnalogX = 127;
	private const sbyte _minAnalogX = -128;
	private const sbyte _maxAnalogY = 127;
	private const sbyte _minAnalogY = -128;
	/// <summary>
	/// Translates controller input from EmuHawk into
	/// N64 controller data
	/// </summary>
	/// <param name="i">Id of controller to update and shove</param>
	public int GetControllerInput(int i)
	{
	_emuCore.InputCallbacks.Call();
	ThisFrameInputPolled = true;
	// Analog stick right = +X
	// Analog stick up = +Y
	string p = "P" + (i + 1);
	sbyte x;
	if (Controller.IsPressed(p + " A Left"))
	{
	x = _minAnalogX;
	}
	else if (Controller.IsPressed(p + " A Right"))
	{
	x = _maxAnalogX;
	}
	else
	{
	x = (sbyte)Controller.AxisValue(p + " X Axis");
	}
	sbyte y;
	if (Controller.IsPressed(p + " A Up"))
	{
	y = _maxAnalogY;
	}
	else if (Controller.IsPressed(p + " A Down"))
	{
	y = _minAnalogY;
	}
	else
	{
	y = (sbyte)Controller.AxisValue(p + " Y Axis");
	}
	int value = ReadController(i + 1);
	value |= (x & 0xFF) << 16;
	value |= (y & 0xFF) << 24;
	return value;
	}

I think it would be better as a static helper method which was shared by both cores.

I've refactored the code into a static helper method in the N64Input class. As a note, I'm working on Linux so I can't test Mupen64, but I've tried to make as few changes as I can to Mupen64-specific code so hopefully it should all work correctly.

[YoshiRulz]

Otherwise LGTM.