Skip to content

Conversation

@vadosnaprimer
Copy link
Collaborator

  • target resolution is deduced automatically by looking at all segments
  • since we can letterbox at native res during initial import, resizing is not involved
  • resize based MS import is incompatible with this setting

msLetterbox is the variable that enables this, has to be set in addition to ms.

fixed #18

…(wonderswan)

- target resolution is deduced automatically by looking at all segments
- since we can letterbox at native res during initial import, resizing is not involved
- resize based MS import is incompatible with this setting
@vadosnaprimer
Copy link
Collaborator Author

Tested on https://tasvideos.org/4829M, seems to work fine.

@despoa
Copy link
Collaborator

despoa commented Jan 23, 2023

Few observations and suggestions:

  • If the sample parameter in msLetterbox isn't going to be used at all, it should be removed, unless Avisynth syntax requires it.
  • In encode.avs, lines 60 and 61 should be right after line 53 to make it clear to the end user that multisegment letterboxing is an option.
  • In the same file, msAudio will be completely ignored and will not work if msLetterbox is true. Here's a possible fix.
if (ms && !msLetterbox) {
	resized = resized \
		.AppendSegment(msBase, msStart, msEnd, msFormat, resizer, hd, pixelType) \
		.ConvertToRGB32()
}

if ( (ms || msLetterbox) && msAudio) {
	resized = AudioDub(resized, WavSource(msAudiotrack))
}

- movie the option around for more clarity
- set msAudioFile path when there's external audio to import, instead of having both path and bool switch
- allow using external audio for msLetterbox
@vadosnaprimer
Copy link
Collaborator Author

Check.

@despoa
Copy link
Collaborator

despoa commented Jan 25, 2023

Looks good.

Copy link
Collaborator

@fsvgm777 fsvgm777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@vadosnaprimer vadosnaprimer merged commit 258ad90 into x64 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing support for WonderSwan roatations in an .avsi by letterboxing.

4 participants