-
Notifications
You must be signed in to change notification settings - Fork 6
Update trackRef field and make it mandatory #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What's the rationale behind making it mandatory? It should still be fine to auto-generate, right? |
|
The reason is that while they are used in the backend for the most part, they should still be related to the chart for readability. |
|
Are there issues if the trackref is nonunique? (E.g. if two charts are made for Adele - Hello and both are called |
|
Yeah, if there's 2 charts with the same trackRef, TrombLoader will only load one of them. |
|
In that case, I think I would still prefer the trackRef to be automatically generated unless the user types something in. This basically guarantees we'll never have a situation where two charts just can't be loaded at the same time. I may still not entirely understand what the readability concern is. Who needs to read this and why? What would be the benefit to the reader to be able to understand what the trackRef means? |
|
Having duplicates will not be a concern since the bot checks the trackRef of an uploaded track against all existing charts and rejects it if the trackRef already exists.
|
|
How would you feel about doing something like In this case, we most likely would be adding a checkbox for whether to prefix with a random number. |
|
Sure, that would work! |
|
If you wanna go all the way to make it convenient tho, you could generate a trackref from the song title (or short name) they entered |
This has been bothing me for way too long so I decided to change it