Skip to content

Update trackRef field and make it mandatory #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update trackRef field and make it mandatory #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e95a19
Change "Folder Name" to "Song trackRef", make it required and update …
Guardevoir Dec 9, 2023
1f738e8
Change "Folder Name" to "Song trackRef", make it required and update …
Guardevoir Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.idea
/.vs
9 changes: 4 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,11 @@ <h3>- Chart info -</h3>

<h3>- Other -</h3>

<abbr title="Name of the song folder, required for old versions of TrombLoader">i</abbr>
<label for="foldername">Folder Name</label>
<input type="text" id="foldername" name="foldername" placeholder="Auto">
<abbr title="Name used internally to identify your chart. (Ideally only contains a-Z, 1-9, _, - and spaces)">i</abbr>
<label for="foldername">Song trackRef</label>
<input type="text" id="foldername" name="foldername">

<abbr
title="The length of the song in measures. Leave this blank unless you need to manually set the endpoint.">i</abbr>
<abbr title="The length of the song in measures. Leave this blank unless you need to manually set the endpoint.">i</abbr>
<label for="songendpoint">Song Endpoint</label>
<input type="number" id="songendpoint" name="songendpoint" placeholder="Auto">
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const Generate = (function () {
if (!Inputs.verifyInputs() || MidiToNotes.notes.length === 0) {
alert(
"Please ensure a valid midi is uploaded and all fields are filled\n" +
"(Folder Name and Song Endpoint can be empty)"
"(Song Endpoint can be empty)"
);
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const Inputs = (function () {
};

/** Inputs that are not required to be filled in */
const optionalInputNames = new Set(["foldername", "songendpoint"]);
const optionalInputNames = new Set(["songendpoint"]);

/** Inputs that need to be formatted as ints */
const intInputNames = new Set([
Expand Down