Skip to content

Comments

fix(date-picker): fixed Date object comparison, fixed WCAG problems #259#269

Merged
mart-sessman merged 2 commits intorcfrom
fix/259-datepicker-disabling-and-selection-issues
Jan 20, 2026
Merged

fix(date-picker): fixed Date object comparison, fixed WCAG problems #259#269
mart-sessman merged 2 commits intorcfrom
fix/259-datepicker-disabling-and-selection-issues

Conversation

@mart-sessman
Copy link
Contributor

also refactored date-picker into smaller components and added closeOnSelect input with default value "true"



also refactored component into smaller components
@mart-sessman mart-sessman requested a review from airikej January 16, 2026 11:22
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 97.31544% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...mponents/form/date-picker/date-picker.component.ts 95.95% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

type: { summary: "boolean" },
defaultValue: { summary: "true" },
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add this badge to this story so users wouldn't expect full functionality from this component yet
https://storybook.tedi.ee/angular/main/?path=/docs/documentation-badge-guide--welcome (partially tedi-ready)

inCurrentMonth: true,
});

expect(hideSpy).not.toHaveBeenCalled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do date-picker-header and date-picker-month-grid components also have tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datepicker tests partially cover them, but yes, agreed, needs more coverage

@mart-sessman mart-sessman merged commit 0a8277f into rc Jan 20, 2026
18 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 20, 2026
# [6.0.0-rc.2](angular-6.0.0-rc.1...angular-6.0.0-rc.2) (2026-01-20)

### Bug Fixes

* **date-picker:** fixed Date object comparison, fixed WCAG problems [#259](#259) ([#269](#269)) ([0a8277f](0a8277f))
@mart-sessman mart-sessman deleted the fix/259-datepicker-disabling-and-selection-issues branch January 20, 2026 08:31
github-actions bot pushed a commit that referenced this pull request Jan 29, 2026
# [6.0.0](angular-5.0.0...angular-6.0.0) (2026-01-29)

### Bug Fixes

* **alert:** changed DOM order of alert elements [#44](#44) ([#278](#278)) ([d5974e3](d5974e3))
* **alert:** fixed close button overlapping text [#282](#282) ([#287](#287)) ([d2c8e1b](d2c8e1b))
* **breadcrumbs:** migrated from ngFor to new [@for](https://github.com/for) loop with proper item tracking [#305](#305) ([#306](#306)) ([c3916b3](c3916b3))
* **button:** added correct focus-visible style [#47](#47) ([#279](#279)) ([431eda9](431eda9))
* **carousel:** carousel wcag fixes [#241](#241) ([#263](#263)) ([91b6913](91b6913))
* **date-picker:** fixed Date object comparison, fixed WCAG problems [#259](#259) ([#269](#269)) ([0a8277f](0a8277f))
* **file-dropzone:** make file dropzone update forms on deletion, and use form validation instead of it's own internal implementation ([#239](#239)) ([86ebc6f](86ebc6f)), closes [#66](#66) [#66](#66) [#66](#66) [#66](#66) [#66](#66)
* **file-dropzone:** remove single console.log [#66](#66) ([#288](#288)) ([3abde8d](3abde8d))
* **header:** fixed header-profile aria-label being read as js code [#291](#291) ([#292](#292)) ([5b626fe](5b626fe))
* **info-button:** added default aria-label [#46](#46) ([#265](#265)) ([a76084f](a76084f))
* **info-button:** fixed circular service import [#46](#46) ([cf49aad](cf49aad))
* **label:** wcag-compliant required label handling [#50](#50) ([#277](#277)) ([ebfdd96](ebfdd96))
* **modal, table-of-contents:** fix import paths [#243](#243) ([#264](#264)) ([2b95a3f](2b95a3f))
* **modal:** use correct z-index variable, default footer align to flex-end [#301](#301) ([#302](#302)) ([c590b0a](c590b0a))
* **number-field:** wcag fixes [#43](#43) ([#286](#286)) ([b24368f](b24368f))
* **row, col, collapse:** added tedi-prefix to class names [#251](#251) ([#274](#274)) ([3064c28](3064c28))
* **sidenav:** added presentation role to list item components [#303](#303) ([#304](#304)) ([1713ac9](1713ac9))
* **sidenav:** fixed SR semantics, added focus handling and styles [#207](#207) ([#289](#289)) ([865fb38](865fb38))
* **text-group, label:** improved SR accessibility, extended tedi-label usage [#49](#49) ([3900e16](3900e16))
* **toggle, number-field:** renamed id to inputId [#24](#24) ([#266](#266)) ([d451a56](d451a56))
* **toggle:** fixed handle position of active state for default size [#256](#256) ([#257](#257)) ([8357069](8357069))
* **tooltip:** wcag improvements [#45](#45) ([#267](#267)) ([a860c06](a860c06))

### Features

* **toast:** toast tedi-ready component [#270](#270) ([#271](#271)) ([d5e7954](d5e7954))
* **vertical-stepper:** add community vertical stepper [#254](#254) ([#296](#296)) ([a5d9e82](a5d9e82))

### BREAKING CHANGES

* **toggle, number-field:** toggle and number-field components must switch to inputId input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants