Skip to content

revert(horizontal-stepper): undo premature rc commits #405#436

Merged
mart-sessman merged 1 commit into
rcfrom
revert/horizontal-stepper-rc
May 8, 2026
Merged

revert(horizontal-stepper): undo premature rc commits #405#436
mart-sessman merged 1 commit into
rcfrom
revert/horizontal-stepper-rc

Conversation

@mart-sessman
Copy link
Copy Markdown
Contributor

@mart-sessman mart-sessman commented May 8, 2026

Summary

Reverts horizontal-stepper commits that were prematurely pushed directly to `rc` and triggered publication of `6.4.0-rc.2` to npm.

Reverted commits:

After this merges, semantic-release will publish `6.4.0-rc.3` without the stepper code. The actual horizontal-stepper feature work continues in #410.

Test plan

  • CI green
  • After merge: verify `6.4.0-rc.3` is published to npm without horizontal-stepper exports

Summary by CodeRabbit

  • Chores
    • Removed HorizontalStepper component and all associated documentation and examples

Reverts 5a9d803 ("feat(horizontal-stepper): fixes from review #405")
and a7d6282 ("feat(horizontal-stepper): new TEDI-ready component #405").

These commits were accidentally pushed directly to rc and triggered
publication of 6.4.0-rc.2. The actual feature work continues in
PR #410 targeting rc.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request removes the entire HorizontalStepper component family from the TEDI Angular design system. The changes systematically delete the component implementation, templates, styles, Storybook stories, test suites, and all related documentation and translations across the codebase.

Changes

HorizontalStepper Component Removal

Layer / File(s) Summary
Public API Exports
tedi/components/navigation/index.ts, tedi/components/navigation/horizontal-stepper/index.ts, tedi/components/navigation/horizontal-stepper/horizontal-stepper-item/index.ts
Re-exports of HorizontalStepperComponent and HorizontalStepperItemComponent are removed from module barrel files, reducing the navigation module's public surface.
Component Implementation
tedi/components/navigation/horizontal-stepper/horizontal-stepper.component.ts, tedi/components/navigation/horizontal-stepper/horizontal-stepper-item/horizontal-stepper-item.component.ts
Component classes and type aliases (HorizontalStepperBackground, HorizontalStepperBreakpoint, HorizontalStepperCompact) are deleted. Removed inputs (ariaLabel, background, compact), content-child collection, and _stepNumber signal management.
Component Templates
tedi/components/navigation/horizontal-stepper/horizontal-stepper.component.html, tedi/components/navigation/horizontal-stepper/horizontal-stepper-item/horizontal-stepper-item.component.html
HTML templates are removed entirely, including the stepper item button markup with indicator rendering and label/description display.
Component Styles
tedi/components/navigation/horizontal-stepper/horizontal-stepper.component.scss, tedi/components/navigation/horizontal-stepper/horizontal-stepper-item/horizontal-stepper-item.component.scss
SCSS stylesheets deleted, including base layouts, state variants (--selected, --completed, --error), and responsive compact breakpoint classes.
Storybook Stories
tedi/components/navigation/horizontal-stepper/horizontal-stepper.stories.ts
All story variants removed: Default, SecondStep, ThirdStep, WithErrors, WithDescriptions, TransparentBackground, AlwaysCompact, CompactAtMdBreakpoint.
Component Tests
tedi/components/navigation/horizontal-stepper/horizontal-stepper.component.spec.ts, tedi/components/navigation/horizontal-stepper/horizontal-stepper-item/horizontal-stepper-item.component.spec.ts
Test suites removed including test host setup, translation mocks, and assertions for rendering, state management, ARIA attributes, and responsive behavior.
Documentation and Translations
skills/tedi-angular/references/components.md, tedi/services/translation/translations.ts
Component reference documentation removed from the skill reference guide; stepper.error translation entry removed from the translations map.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • ly-tempel-bitweb
  • airikej
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and accurately describes the main change: reverting horizontal-stepper commits that were prematurely pushed to the rc branch.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/horizontal-stepper-rc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mart-sessman mart-sessman changed the title revert(horizontal-stepper): undo accidental rc commits #405 revert(horizontal-stepper): undo premature rc commits #405 May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mart-sessman mart-sessman merged commit a575670 into rc May 8, 2026
18 checks passed
@mart-sessman mart-sessman deleted the revert/horizontal-stepper-rc branch May 8, 2026 14:23
github-actions Bot pushed a commit that referenced this pull request May 18, 2026
# [6.4.0-rc.3](angular-6.4.0-rc.2...angular-6.4.0-rc.3) (2026-05-18)

### Bug Fixes

* **collapse:** add button type to prevent form submission [#434](#434) ([#441](#441)) ([2e13aef](2e13aef))

### Reverts

* **horizontal-stepper:** undo premature rc commits [#405](#405) ([#436](#436)) ([a575670](a575670))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant