Skip to content

fix(variables): update core version, update variable names #592#598

Merged
airikej merged 2 commits into
rcfrom
fix/592-update-core-and-replace-base-variables-with-new-ones
Apr 14, 2026
Merged

fix(variables): update core version, update variable names #592#598
airikej merged 2 commits into
rcfrom
fix/592-update-core-and-replace-base-variables-with-new-ones

Conversation

@airikej
Copy link
Copy Markdown
Contributor

@airikej airikej commented Apr 14, 2026

Summary by CodeRabbit

  • Chores

    • Upgraded @tedi-design-system/core dependency from v3.3.0 to v6.0.0.
  • Style

    • Updated design token references throughout the application to align with the latest design system, improving visual consistency across buttons, forms, layouts, and map components.

@airikej airikej linked an issue Apr 14, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@airikej has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 891a8a9e-8d2a-433b-ab38-f19ac3e6678d

📥 Commits

Reviewing files that changed from the base of the PR and between e2c486a and ddb1ece.

📒 Files selected for processing (1)
  • src/community/components/map-components/base-map-selection/base-map-selection.module.scss
📝 Walkthrough

Walkthrough

The PR upgrades @tedi-design-system/core from version 3.3.0 to 6.0.0 and systematically migrates CSS custom properties across the codebase from legacy tokens (e.g., --borders-*, --dimensions-*, --size-*, --radius-*) to their --tedi-* prefixed equivalents in alignment with the updated design system.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Updated @tedi-design-system/core from 3.3.0 to 6.0.0.
Map Component Styling
src/community/components/map-components/base-map-selection/base-map-selection.module.scss, src/community/components/map-components/button-group/button-group.module.scss, src/community/components/map-components/color-and-icon-picker/color-and-icon-picker.module.scss, src/community/components/map-components/legend/legend.module.scss, src/community/components/map-components/map-button/map-button.module.scss, src/community/components/map-components/map-info/map-info.module.scss
Migrated CSS variables from legacy tokens (--borders-*, --dimensions-*, --size-*) to --tedi-* prefixed equivalents across border-radius, focus/hover outlines, typography sizing, and dimension references.
Map Component Variables
src/community/styles/_map-component.variables.scss
Updated 20+ CSS custom property definitions (button sizing, sidepanel padding, timeline layout, measure line width, drag indicators, tree width, form radio sizing, sidebar padding) to reference --tedi-* tokens instead of legacy equivalents across all responsive breakpoints.
Tedi Button & Layout Components
src/tedi/components/buttons/collapse/collapse.module.scss, src/tedi/components/layout/sidenav/components/sidenav-dropdown/sidenav-dropdown.module.scss, src/tedi/components/layout/sidenav/components/sidenav-toggle/sidenav-toggle.module.scss, src/tedi/components/layout/sidenav/sidenav.module.scss
Migrated focus outline borders, border-radius, icon sizing, and typography font-size references from legacy tokens to --tedi-* equivalents.
Tedi Form & Content Components
src/tedi/components/content/text-group/text-group.module.scss, src/tedi/components/form/choice-group/components/choice-group-item/choice-group-item.module.scss, src/tedi/components/form/select/select.module.scss
Updated margin/spacing and border-related CSS variables; choice-group-item also updated border color token from --filter-primary-inactive-background to --form-checkbox-radio-card-primary-default-border-group.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly Related Issues

Poem

🐰 Tokens dance in tedi's gleam,
Old borders fade, a new design's dream,
From legacy leaves to prefixed grace,
Our styles migrate to their rightful place.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main changes: updating the core dependency version from 3.3.0 to 6.0.0 and replacing legacy CSS variable names with new --tedi-* prefixed tokens throughout multiple SCSS files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/592-update-core-and-replace-base-variables-with-new-ones

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 46: The package.json dependency entry for "@tedi-design-system/core" is
set to a non-existent "6.0.0" version; update the dependency (the line with
"@tedi-design-system/core": "6.0.0") to a valid released version (e.g., "3.2.0")
or the intended target version, then run npm/yarn install to verify resolution
and adjust any import/compatibility changes if you chose a different major
version.

In
`@src/community/components/map-components/base-map-selection/base-map-selection.module.scss`:
- Line 110: The CSS rule using outline: var(--tedi-tedi-borders-01) solid
var(--tedi-primary-500) contains a duplicated prefix; change the custom property
to the correct token var(--tedi-borders-01) in the
base-map-selection.module.scss rule (the declaration with outline:
var(--tedi-tedi-borders-01) ...), and verify there are no other instances of
--tedi-tedi-borders-01 remaining in this file so it matches the existing tokens
at lines where --tedi-borders-01 is already used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 67825f01-4ea4-4620-897a-dddb85f05809

📥 Commits

Reviewing files that changed from the base of the PR and between 5e20a70 and e2c486a.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (15)
  • package.json
  • src/community/components/map-components/base-map-selection/base-map-selection.module.scss
  • src/community/components/map-components/button-group/button-group.module.scss
  • src/community/components/map-components/color-and-icon-picker/color-and-icon-picker.module.scss
  • src/community/components/map-components/legend/legend.module.scss
  • src/community/components/map-components/map-button/map-button.module.scss
  • src/community/components/map-components/map-info/map-info.module.scss
  • src/community/styles/_map-component.variables.scss
  • src/tedi/components/buttons/collapse/collapse.module.scss
  • src/tedi/components/content/text-group/text-group.module.scss
  • src/tedi/components/form/choice-group/components/choice-group-item/choice-group-item.module.scss
  • src/tedi/components/form/select/select.module.scss
  • src/tedi/components/layout/sidenav/components/sidenav-dropdown/sidenav-dropdown.module.scss
  • src/tedi/components/layout/sidenav/components/sidenav-toggle/sidenav-toggle.module.scss
  • src/tedi/components/layout/sidenav/sidenav.module.scss

Comment thread package.json
@airikej airikej merged commit 1f15b36 into rc Apr 14, 2026
21 checks passed
@airikej airikej deleted the fix/592-update-core-and-replace-base-variables-with-new-ones branch April 14, 2026 08:52
github-actions Bot pushed a commit that referenced this pull request Apr 14, 2026
# [17.0.0-rc.2](react-17.0.0-rc.1...react-17.0.0-rc.2) (2026-04-14)

### Bug Fixes

* **variables:** update core version, update variable names [#592](#592) ([#598](#598)) ([1f15b36](1f15b36))
github-actions Bot pushed a commit that referenced this pull request Apr 29, 2026
# [17.0.0](react-16.1.0...react-17.0.0) (2026-04-29)

### Bug Fixes

* **checkbox:** invalid indicator hover border fix [#605](#605) ([#609](#609)) ([f1d62c6](f1d62c6))
* **select:** select placeholder no longer blocks context menu interactions [#584](#584) ([#585](#585)) ([e8d86ab](e8d86ab))
* **variables:** update core version, update variable names [#592](#592) ([#598](#598)) ([1f15b36](1f15b36))

### Features

* **button-group:** add mobile variant [#448](#448) ([#606](#606)) ([54dee90](54dee90)), closes [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94) [#94](#94)
* **card:** add more control to borderRadius usage, add examples [#444](#444) ([#597](#597)) ([deac9db](deac9db))
* **print:** introduce PrintingProvider + context-based usePrint [#99](#99) ([#497](#497)) ([a58cb70](a58cb70))
* **spinner:** add new sizes [#586](#586) ([#589](#589)) ([fbea0c3](fbea0c3))
* **tabs:** new tedi-ready component [#555](#555) ([#557](#557)) ([9c06c51](9c06c51))
* **textarea:** add autoGrow, height and maxHeight props [#588](#588) ([#593](#593)) ([2c86740](2c86740))
* **toggle:** new TEDI-Ready component [#305](#305) ([#594](#594)) ([6f28045](6f28045))

### BREAKING CHANGES

* **print:** usePrint hook removed.
Replace with usePrint from the new PrintingProvider context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update core and replace base variables with new ones

2 participants