feat(closing-button): align size and icon behavior with the design #43#481
Merged
feat(closing-button): align size and icon behavior with the design #43#481
Conversation
BREAKING CHANGE: size, iconSize changes, new default values
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| const renderClearButton = React.useMemo(() => { | ||
| const clearButtonProps = { | ||
| size: (size === 'large' ? 'large' : 'medium') as 'medium' | 'large', | ||
| iconSize: size === 'large' ? (24 as const) : (18 as const), |
Contributor
There was a problem hiding this comment.
casting as const could be grouped
| import styles from './closing-button.module.scss'; | ||
|
|
||
| type ClosingButtonSize = 'medium' | 'large'; | ||
| export type ClosingButtonSize = 'default' | 'small'; |
Contributor
There was a problem hiding this comment.
breaking change? If this button can be used separately
Contributor
Author
There was a problem hiding this comment.
yes breaking change also the migration guide is in the original task
mart-sessman
approved these changes
Jan 29, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
# [16.0.0](react-15.0.0...react-16.0.0) (2026-02-26) ### Bug Fixes * **checkbox,radio:** pass required prop to label [#115](#115) ([#498](#498)) ([a569636](a569636)), closes [#486](#486) * **checkbox,radio:** show pointer on label hover [#532](#532) ([#533](#533)) ([097627d](097627d)) * **choice-group:** prevent calling onchange twice on card variant [#484](#484) ([#502](#502)) ([27799cc](27799cc)) * **choice-group:** prevent double change events and unify card click behavior [#504](#504) ([#505](#505)) ([7ea1fed](7ea1fed)) * **choice-group:** segmented item borders and focus behaviour [#101](#101) ([#513](#513)) ([455c491](455c491)) * **choice-group:** selected disabled choice-group item fixes [#27](#27) ([#510](#510)) ([be8884e](be8884e)) * **feedback-text:** fix error/success text color variables [#517](#517) ([#521](#521)) ([c019e79](c019e79)) * **link:** fix link icon sizes in relation to figma design [#46](#46) ([#520](#520)) ([f32bd83](f32bd83)) * **number-field:** fix variables [#516](#516) ([#522](#522)) ([dcf6240](dcf6240)) * **separator:** fix custom size application [#535](#535) ([#536](#536)) ([130edcd](130edcd)) * **sidenav:** apply linkAs for flyout items [#40](#40) ([#501](#501)) ([6007ede](6007ede)) * **text-field:** fix small textfield right area padding, fix small textfield font size [#527](#527) ([#528](#528)) ([bd8bd16](bd8bd16)) * **tooltip,overlay:** wcag improvements [#468](#468) ([#491](#491)) ([fa60e46](fa60e46)) ### Features * **alert:** new size prop with default and small values [#11](#11) ([#509](#509)) ([35c4962](35c4962)) * **button-group:** add size prop, add small example, fix examples on storybook [#14](#14) ([#511](#511)) ([73cd4f1](73cd4f1)) * **closing-button:** add brand and inverted color [#6](#6) ([#519](#519)) ([cfeb5f2](cfeb5f2)) * **closing-button:** align size and icon behavior with the design [#43](#43) ([#481](#481)) ([cdd92a8](cdd92a8)) * **form-label:** update label prop type to ReactNode [#486](#486) ([#490](#490)) ([2c1152a](2c1152a)) * **info-button:** added inverted variant and new color prop [#420](#420) ([#508](#508)) ([6ca2d7f](6ca2d7f)) * **separator:** redesign with new spacing API, dotPosition and dotStyle support [#30](#30) ([#525](#525)) ([93e9e11](93e9e11)) * **sidenav:** subheading as ReactNode, fix mobile sidenav items padding [#421](#421) ([#512](#512)) ([bb7fbe8](bb7fbe8)) ### BREAKING CHANGES * **separator:** legacy spacing props removed, dotSize enum changed, variant values simplified * **closing-button:** size, iconSize changes, new default values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.