Skip to content

Conversation

@Minei3oat
Copy link
Contributor

This PR adds two features to the iCal endpoint:

  • use ctf id and pad domain as persistent UID
    • currently a UUID is generated for each request
    • the spec requires the UID to be persistent
  • add ctftime_url as ATTACH
    • this allows to retrieve more information about the ctf from ctftime

@JJ-8
Copy link
Collaborator

JJ-8 commented Dec 11, 2024

Hi @Minei3oat, thank you for your contribution! I have not tested your code yet but I added one question to my review, please see above. Thanks!

@JJ-8 JJ-8 self-requested a review December 16, 2024 10:10
@JJ-8 JJ-8 merged commit 559d33e into TFNS:main Dec 16, 2024
4 checks passed
@Minei3oat Minei3oat deleted the improve-calendar branch December 16, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants