Skip to content

Conversation

@tasansal
Copy link
Collaborator

@tasansal tasansal commented Oct 18, 2025

@tasansal tasansal requested a review from BrianMichell October 18, 2025 12:46
@tasansal tasansal self-assigned this Oct 18, 2025
@tasansal tasansal added the documentation Improvements or additions to documentation label Oct 18, 2025
@tasansal tasansal marked this pull request as ready for review October 18, 2025 12:50
@tasansal tasansal force-pushed the custom-template-tutorial branch from 1672eb5 to 5ce6c42 Compare October 18, 2025 22:47
@tasansal tasansal changed the title Add template tutorial including custom Add template tutorial including custom template registry. Oct 20, 2025
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. The HTML representations seem to have gotten a little worse for certain elements though. Not sure if there's anything we can do since these are third-party representations though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the docs page theme is set to "auto" the html repr in Making Dummy Xarray Dataset section is very difficult to read if system is set to dark. The repr is responsive to explicit modes "dark" and "light".

Auto

Image

Light

Image

Dark

Image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TQDM progress bars are hard to read in "dark" mode.

Light

Image

Dark/Auto

Image

@tasansal tasansal merged commit 693bf0b into main Oct 20, 2025
16 checks passed
@tasansal tasansal deleted the custom-template-tutorial branch October 20, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a tutorial page for building and registering custom templates

3 participants