Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

This PR builds on top of #731 to finish the implementation of all remaining grid overrides.

I think there is a lot of complexity that is added by these changes that should maybe live elsewhere.

Resolves #612

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 77.20588% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.08%. Comparing base (c3ba558) to head (c099fe0).
⚠️ Report is 220 commits behind head on main.

Files with missing lines Patch % Lines
src/mdio/segy/utilities.py 82.97% 4 Missing and 4 partials ⚠️
src/mdio/segy/geometry.py 73.07% 4 Missing and 3 partials ⚠️
src/mdio/builder/templates/base.py 54.54% 4 Missing and 1 partial ⚠️
...integration/test_import_streamer_grid_overrides.py 44.44% 4 Missing and 1 partial ⚠️
src/mdio/converters/segy.py 80.95% 1 Missing and 3 partials ⚠️
src/mdio/builder/dataset_builder.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   85.30%   88.08%   +2.77%     
==========================================
  Files          46       90      +44     
  Lines        2219     5112    +2893     
  Branches      306      358      +52     
==========================================
+ Hits         1893     4503    +2610     
- Misses        281      522     +241     
- Partials       45       87      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell BrianMichell marked this pull request as ready for review October 28, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid Overrides

2 participants