Skip to content

Fix grid override selection bug#808

Merged
BrianMichell merged 3 commits intoTGSAI:mainfrom
BrianMichell:fix-geometry-bug
Apr 16, 2026
Merged

Fix grid override selection bug#808
BrianMichell merged 3 commits intoTGSAI:mainfrom
BrianMichell:fix-geometry-bug

Conversation

@BrianMichell
Copy link
Copy Markdown
Collaborator

Fix geometry detection in analyze_lines_for_guns to handle Type A cases correctly. Ensure all shot lines are processed and unique_guns_per_line is populated to prevent KeyError. Add tests for multiline Type A geometry scenarios.

…es correctly. Ensure all shot lines are processed and unique_guns_per_line is populated to prevent KeyError. Add tests for multiline Type A geometry scenarios.
@BrianMichell BrianMichell added the bug Something isn't working label Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (c3ba558) to head (105fe6a).
⚠️ Report is 229 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   85.30%   89.55%   +4.24%     
==========================================
  Files          46      104      +58     
  Lines        2219     6135    +3916     
  Branches      306      408     +102     
==========================================
+ Hits         1893     5494    +3601     
- Misses        281      543     +262     
- Partials       45       98      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell BrianMichell merged commit 7be45a7 into TGSAI:main Apr 16, 2026
9 checks passed
@BrianMichell BrianMichell deleted the fix-geometry-bug branch April 16, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant