Enhance dataset templates with coordinate specifications#822
Merged
BrianMichell merged 1 commit intoJun 1, 2026
Merged
Conversation
* Introduce `declare_coordinate_specs` method in various seismic dataset templates to define non-dimension coordinates. * Implement `CoordinateSpec` class for better structure and validation of coordinate specifications. * Update existing templates to utilize the new coordinate declaration method, ensuring consistency across 2D and 3D seismic templates. * Add temporary drift guard to validate synchronization between declared and built coordinates, to be removed in future releases. * Introduce unit tests for schema resolution and coordinate specification validation to ensure robustness.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 85.30% 92.37% +7.06%
==========================================
Files 46 130 +84
Lines 2219 7830 +5611
Branches 306 468 +162
==========================================
+ Hits 1893 7233 +5340
- Misses 281 515 +234
- Partials 45 82 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declare_coordinate_specsmethod in various seismic dataset templates to define non-dimension coordinates.CoordinateSpecclass for better structure and validation of coordinate specifications.