Skip to content

Refactor room tab personalized links#1007

Merged
samuelwei merged 12 commits intodevelopfrom
refactor-room-tab-personalized-links
Apr 22, 2024
Merged

Refactor room tab personalized links#1007
samuelwei merged 12 commits intodevelopfrom
refactor-room-tab-personalized-links

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Apr 15, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Backend: Add sorting / filtering
  • Frontend: Replace dataTable with dataView

Other information

Refactoring the layout of the room tab personalized links to optimize for small screens, replace table with a flex layout

@samuelwei samuelwei added this to the v4.0 milestone Apr 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (fbdf6f2) to head (a23b947).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1007      +/-   ##
=============================================
+ Coverage      95.74%   95.76%   +0.02%     
- Complexity      1080     1091      +11     
=============================================
  Files            178      178              
  Lines           3803     3829      +26     
=============================================
+ Hits            3641     3667      +26     
  Misses           162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei requested a review from danielmachill April 19, 2024 08:44
@samuelwei samuelwei merged commit d87c484 into develop Apr 22, 2024
@samuelwei samuelwei deleted the refactor-room-tab-personalized-links branch June 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant