Skip to content

Add option to search for email#1120

Merged
samuelwei merged 3 commits intodevelopfrom
improve-search
Jun 5, 2024
Merged

Add option to search for email#1120
samuelwei merged 3 commits intodevelopfrom
improve-search

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Jun 4, 2024

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add email to list of attributes the search for users should be performed on

Other information

@samuelwei samuelwei added this to the v4.0 milestone Jun 4, 2024
@samuelwei samuelwei requested a review from danielmachill June 4, 2024 13:43
@samuelwei samuelwei marked this pull request as ready for review June 4, 2024 13:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (2210d37) to head (5a50f16).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1120   +/-   ##
==========================================
  Coverage      95.84%   95.84%           
- Complexity      1294     1295    +1     
==========================================
  Files            198      198           
  Lines           4425     4427    +2     
==========================================
+ Hits            4241     4243    +2     
  Misses           184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread app/Models/User.php Outdated
@samuelwei samuelwei merged commit aece6a8 into develop Jun 5, 2024
@samuelwei samuelwei deleted the improve-search branch June 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants