Skip to content

Refactor TESTING_BBB env variable#1159

Merged
samuelwei merged 2 commits intodevelopfrom
restructure-bbb-testing-server
Jun 19, 2024
Merged

Refactor TESTING_BBB env variable#1159
samuelwei merged 2 commits intodevelopfrom
restructure-bbb-testing-server

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Jun 18, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Replace TESTING_BBB env variable for integration tests with BBB_TEST_SERVER_HOST and BBB_TEST_SERVER_SECRET

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (3c9ec27) to head (fcab516).
Report is 1 commits behind head on develop.

Current head fcab516 differs from pull request most recent head b7b4522

Please upload reports for the commit b7b4522 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1159      +/-   ##
=============================================
+ Coverage      95.84%   95.86%   +0.02%     
  Complexity      1295     1295              
=============================================
  Files            198      198              
  Lines           4427     4427              
=============================================
+ Hits            4243     4244       +1     
+ Misses           184      183       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 18, 2024

Passing run #72 ↗︎

0 34 0 0 Flakiness 0

Details:

Refactor TESTING_BBB env variable (#1159)
Project: PILOS Commit: 1c87660da7
Status: Passed Duration: 00:36 💡
Started: Jun 19, 2024 6:34 AM Ended: Jun 19, 2024 6:34 AM

Review all test suite changes for PR #1159 ↗︎

@samuelwei samuelwei merged commit 1c87660 into develop Jun 19, 2024
@samuelwei samuelwei deleted the restructure-bbb-testing-server branch June 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant