Skip to content

Add cypress system tests#1166

Merged
samuelwei merged 18 commits intodevelopfrom
add-cypress-integration-tests
Jul 8, 2024
Merged

Add cypress system tests#1166
samuelwei merged 18 commits intodevelopfrom
add-cypress-integration-tests

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Jun 19, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add some basic system tests to test the whole pipline: Docker Image -> Docker Compose -> Backend <- API -> Frontend

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (0b66f73) to head (faac71b).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1166   +/-   ##
==========================================
  Coverage      95.89%   95.89%           
  Complexity      1298     1298           
==========================================
  Files            201      201           
  Lines           4462     4462           
==========================================
  Hits            4279     4279           
  Misses           183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 20, 2024

Passing run #149 ↗︎

0 46 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Add cypress system tests (#1166)
Project: PILOS Commit: d786f0dc67
Status: Passed Duration: 03:00 💡
Started: Jul 8, 2024 11:30 AM Ended: Jul 8, 2024 11:33 AM

Review all test suite changes for PR #1166 ↗︎

@samuelwei samuelwei changed the title Add cypress integration tests Add cypress system tests Jun 20, 2024
@samuelwei samuelwei requested a review from Sabr1n4W June 20, 2024 11:10
Copy link
Copy Markdown
Contributor

@Sabr1n4W Sabr1n4W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly not reviewed yet but maybe add following changes:

  • Replace .should('contain', '...') with .should('have.text', '...'), .should('include.text', '...') or .should('include', '...') (last one mostly for checking url)
  • Add .should('be.visible') after cy.contains('...') when checking if a specific text is shown to make sure that it is really visible

Changes will most likely also be added for the frontend tests (#1150, 8dd2dfc)

@samuelwei samuelwei added this to the v4.0 milestone Jul 5, 2024
@samuelwei samuelwei merged commit d786f0d into develop Jul 8, 2024
@samuelwei samuelwei deleted the add-cypress-integration-tests branch July 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants