Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1166 +/- ##
==========================================
Coverage 95.89% 95.89%
Complexity 1298 1298
==========================================
Files 201 201
Lines 4462 4462
==========================================
Hits 4279 4279
Misses 183 183 ☔ View full report in Codecov by Sentry. |
Passing run #149 ↗︎
Details:
Review all test suite changes for PR #1166 ↗︎ |
||||||||||||||||||||
Sabr1n4W
reviewed
Jun 20, 2024
Contributor
Sabr1n4W
left a comment
There was a problem hiding this comment.
Mostly not reviewed yet but maybe add following changes:
- Replace .should('contain', '...') with .should('have.text', '...'), .should('include.text', '...') or .should('include', '...') (last one mostly for checking url)
- Add .should('be.visible') after cy.contains('...') when checking if a specific text is shown to make sure that it is really visible
Changes will most likely also be added for the frontend tests (#1150, 8dd2dfc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type (Highlight the corresponding type)
Checklist
Changes