Skip to content

Improve LDAP#1252

Merged
samuelwei merged 7 commits intodevelopfrom
improve-ldap
Jul 29, 2024
Merged

Improve LDAP#1252
samuelwei merged 7 commits intodevelopfrom
improve-ldap

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Jul 29, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fixed ldap debug logging
  • Fix wrong path for ldap.conf (introduced in Reduce docker image size #792)
  • Add docs for ssl / tls using ldap
  • Change local openldap connection example to use tls

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (12ba6ab) to head (13308d2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1252      +/-   ##
=============================================
- Coverage      95.51%   95.49%   -0.03%     
  Complexity      1304     1304              
=============================================
  Files            202      202              
  Lines           4530     4530              
=============================================
- Hits            4327     4326       -1     
- Misses           203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Jul 29, 2024

Passing run #281 ↗︎

0 46 0 0 Flakiness 0

Details:

Improve LDAP (#1252)
Project: PILOS Commit: 91f8be2058
Status: Passed Duration: 02:56 💡
Started: Jul 29, 2024 1:20 PM Ended: Jul 29, 2024 1:23 PM

Review all test suite changes for PR #1252 ↗︎

@samuelwei samuelwei merged commit 91f8be2 into develop Jul 29, 2024
@samuelwei samuelwei deleted the improve-ldap branch March 25, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant