Skip to content

Disable file upload UI elements during upload#1449

Merged
samuelwei merged 1 commit intodevelopfrom
improve-ux-file-upload
Oct 1, 2024
Merged

Disable file upload UI elements during upload#1449
samuelwei merged 1 commit intodevelopfrom
improve-ux-file-upload

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.): UX
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Disable file upload UI elements during upload
  • Fix client error on 401/403 errors

+ fix error on 401/403 errors
@samuelwei samuelwei added bug Something isn't working UI User Interface labels Sep 30, 2024
@samuelwei samuelwei requested a review from Sabr1n4W September 30, 2024 11:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (2a62d5a) to head (9e769ab).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1449   +/-   ##
==========================================
  Coverage      95.34%   95.34%           
  Complexity      1323     1323           
==========================================
  Files            203      203           
  Lines           4579     4579           
==========================================
  Hits            4366     4366           
  Misses           213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Sep 30, 2024

PILOS    Run #748

Run Properties:  status check passed Passed #748  •  git commit 4734e347e8: Disable file upload UI elements during upload (#1449)
Project PILOS
Branch Review develop
Run status status check passed Passed #748
Run duration 02m 58s
Commit git commit 4734e347e8: Disable file upload UI elements during upload (#1449)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

@samuelwei samuelwei merged commit 4734e34 into develop Oct 1, 2024
@samuelwei samuelwei deleted the improve-ux-file-upload branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants