Skip to content

Fix js warnings and form ids#1452

Merged
samuelwei merged 16 commits intodevelopfrom
fix-js-warnings-and-form-ids
Oct 16, 2024
Merged

Fix js warnings and form ids#1452
samuelwei merged 16 commits intodevelopfrom
fix-js-warnings-and-form-ids

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Oct 1, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fix wrong and missing ids and labels in forms
  • Improve autocomplete in user profile
  • Lazy load profile tabs to prevent form id issues
  • Fix js warnings for invalid prop types [dev. only]
  • Disable missing locales warnings [dev. only]

@cypress
Copy link
Copy Markdown

cypress Bot commented Oct 1, 2024

PILOS    Run #858

Run Properties:  status check passed Passed #858  •  git commit 08ba3fcfeb: Fix js warnings and form ids (#1452)
Project PILOS
Run status status check passed Passed #858
Run duration 02m 58s
Commit git commit 08ba3fcfeb: Fix js warnings and form ids (#1452)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 49

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (f079fec) to head (ec9057e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1452   +/-   ##
==========================================
  Coverage      95.35%   95.35%           
  Complexity      1321     1321           
==========================================
  Files            202      202           
  Lines           4582     4582           
==========================================
  Hits            4369     4369           
  Misses           213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei added the bug Something isn't working label Oct 1, 2024
@samuelwei samuelwei added this to the v4.1 milestone Oct 1, 2024
@samuelwei samuelwei requested a review from Sabr1n4W October 15, 2024 11:29
@samuelwei samuelwei merged commit 08ba3fc into develop Oct 16, 2024
@samuelwei samuelwei deleted the fix-js-warnings-and-form-ids branch October 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants