Skip to content

Improve accessibility#1489

Merged
samuelwei merged 4 commits intodevelopfrom
improve-accessibility
Oct 17, 2024
Merged

Improve accessibility#1489
samuelwei merged 4 commits intodevelopfrom
improve-accessibility

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Improve accessibility for icon only buttons
  • Fix text truncate in data tables
  • Fix header order (h1 -> h6)

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05%. Comparing base (e2e051f) to head (850ebf2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1489   +/-   ##
==========================================
  Coverage      76.05%   76.05%           
  Complexity      1321     1321           
==========================================
  Files            359      358    -1     
  Lines           8765     8763    -2     
  Branches         670      670           
==========================================
- Hits            6666     6665    -1     
+ Misses          2099     2098    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Oct 17, 2024

PILOS    Run #884

Run Properties:  status check failed Failed #884  •  git commit 7f53b1e3af: Improve accessibility (#1489)
Project PILOS
Run status status check failed Failed #884
Run duration 03m 38s
Commit git commit 7f53b1e3af: Improve accessibility (#1489)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 176

Tests for review

Failed  tests/Frontend/e2e/RoomsViewDescription.cy.js • 1 failed test • Frontend tests

View Output

Test Artifacts
Rooms view description > edit description Test Replay Screenshots

@samuelwei samuelwei merged commit 7f53b1e into develop Oct 17, 2024
@samuelwei samuelwei deleted the improve-accessibility branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant