Skip to content

Fix meeting start and server polling timing conflict#1608

Merged
samuelwei merged 5 commits intodevelopfrom
1607-meeting-marked-as-ended-prematurely-due-to-timing-conflict-between-bbb-api-and-server-poller
Nov 22, 2024
Merged

Fix meeting start and server polling timing conflict#1608
samuelwei merged 5 commits intodevelopfrom
1607-meeting-marked-as-ended-prematurely-due-to-timing-conflict-between-bbb-api-and-server-poller

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Nov 22, 2024

Fixes #1607

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Fix meeting marked as ended prematurely during starting phase of a new meeting
  • Add logging for server health changes
  • Add logging for detached meeting handling
  • Add logging for meeting not running on BBB server

@samuelwei samuelwei marked this pull request as ready for review November 22, 2024 14:35
@samuelwei samuelwei added this to the v4.1 milestone Nov 22, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (1b6e457) to head (34569ac).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/Services/ServerService.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1608      +/-   ##
=============================================
+ Coverage      80.85%   80.93%   +0.07%     
- Complexity      1322     1331       +9     
=============================================
  Files            359      359              
  Lines           9141     9182      +41     
  Branches         845      845              
=============================================
+ Hits            7391     7431      +40     
- Misses          1750     1751       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cypress
Copy link
Copy Markdown

cypress Bot commented Nov 22, 2024

PILOS    Run #1149

Run Properties:  status check passed Passed #1149  •  git commit d1216f001a: Fix meeting start and server polling timing conflict (#1608)
Project PILOS
Branch Review develop
Run status status check passed Passed #1149
Run duration 05m 15s
Commit git commit d1216f001a: Fix meeting start and server polling timing conflict (#1608)
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 236
View all changes introduced in this branch ↗︎

@samuelwei samuelwei merged commit d1216f0 into develop Nov 22, 2024
@samuelwei samuelwei deleted the 1607-meeting-marked-as-ended-prematurely-due-to-timing-conflict-between-bbb-api-and-server-poller branch March 25, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting Marked as Ended Prematurely Due to Timing Conflict Between BBB API and Server Poller

2 participants