Fix reload room type list on form validation error in new room dialog#1616
Merged
Fix reload room type list on form validation error in new room dialog#1616
Conversation
PILOS
|
||||||||||||||||||||||||||||
| Project |
PILOS
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 04m 49s |
| Commit |
|
| Committer | Samuel Weirich |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
237
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1616 +/- ##
=============================================
+ Coverage 80.97% 81.00% +0.02%
Complexity 1338 1338
=============================================
Files 361 361
Lines 9204 9206 +2
Branches 845 847 +2
=============================================
+ Hits 7453 7457 +4
+ Misses 1751 1749 -2 ☔ View full report in Codecov by Sentry. |
Sabr1n4W
requested changes
Nov 25, 2024
Contributor
Sabr1n4W
left a comment
Sabr1n4W
left a comment
There was a problem hiding this comment.
Not completely sure about the reload yet.
Definitely makes sense when an invalid room type was selected and works well there.
Currently also reloads if no room type was selected which is not really needed.
Co-authored-by: Sabrina Wüst <119059706+Sabr1n4W@users.noreply.github.com>
samuelwei
force-pushed
the
1523-code-debt-commented-code
branch
from
28c1b01 to
59090ce
Compare
Sabr1n4W
requested changes
Nov 28, 2024
Sabr1n4W
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1523
Type (Highlight the corresponding type)
Checklist
Changes