Skip to content

Add rate limiting and logging for room auth#1617

Merged
samuelwei merged 12 commits intodevelopfrom
669-add-more-logging-and-rate-limiting
Nov 28, 2024
Merged

Add rate limiting and logging for room auth#1617
samuelwei merged 12 commits intodevelopfrom
669-add-more-logging-and-rate-limiting

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Nov 25, 2024

Fixes #669

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add rate limiting for room auth using access code
  • Add logging for room auth

@samuelwei samuelwei linked an issue Nov 25, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (878e387) to head (e9857bc).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1617      +/-   ##
=============================================
+ Coverage      81.00%   81.06%   +0.06%     
- Complexity      1338     1340       +2     
=============================================
  Files            361      361              
  Lines           9206     9222      +16     
  Branches         847      851       +4     
=============================================
+ Hits            7457     7476      +19     
+ Misses          1749     1746       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link
Copy Markdown

cypress Bot commented Nov 25, 2024

PILOS    Run #1271

Run Properties:  status check passed Passed #1271  •  git commit e9857bc9a2: Add rate limiting and logging for room auth
Project PILOS
Branch Review 669-add-more-logging-and-rate-limiting
Run status status check passed Passed #1271
Run duration 04m 49s
Commit git commit e9857bc9a2: Add rate limiting and logging for room auth
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

@samuelwei samuelwei marked this pull request as ready for review November 25, 2024 16:02
@samuelwei samuelwei requested a review from Sabr1n4W November 25, 2024 16:03
@samuelwei samuelwei added this to the v4.2 milestone Nov 25, 2024
Comment thread app/Http/Middleware/RoomAuthenticate.php Outdated
samuelwei and others added 3 commits November 27, 2024 15:12
Co-authored-by: Sabrina Wüst <119059706+Sabr1n4W@users.noreply.github.com>
@samuelwei samuelwei force-pushed the 669-add-more-logging-and-rate-limiting branch from f16cd9b to 8fa6ab9 Compare November 27, 2024 15:37
Comment thread resources/js/views/RoomsView.vue
samuelwei and others added 2 commits November 28, 2024 15:53
Co-authored-by: Sabrina Wüst <119059706+Sabr1n4W@users.noreply.github.com>
@samuelwei samuelwei merged commit 55db8c6 into develop Nov 28, 2024
@samuelwei samuelwei modified the milestones: v4.2, v4.1 Dec 19, 2024
@samuelwei samuelwei deleted the 669-add-more-logging-and-rate-limiting branch March 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more logging and rate limiting

2 participants