Fix: Room description editor not closed after 403 error on save#3000
Merged
Fix: Room description editor not closed after 403 error on save#3000
Conversation
Agent-Logs-Url: https://github.com/THM-Health/PILOS/sessions/57eb2bde-d654-4bd5-a36e-d662de3341fb Co-authored-by: Sabr1n4W <119059706+Sabr1n4W@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix room description editor not closing after 403 error on save
Fix: Room description editor not closed after 403 error on save
Mar 30, 2026
…escription-editor-403-error # Conflicts: # CHANGELOG.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3000 +/- ##
=============================================
- Coverage 97.14% 96.70% -0.44%
- Complexity 0 1905 +1905
=============================================
Files 179 445 +266
Lines 6314 12885 +6571
Branches 2076 2077 +1
=============================================
+ Hits 6134 12461 +6327
- Misses 180 424 +244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PILOS
|
||||||||||||||||||||||||||||
| Project |
PILOS
|
| Branch Review |
copilot/fix-room-description-editor-403-error
|
| Run status |
|
| Run duration | 07m 12s |
| Commit |
|
| Committer | Copilot |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
622
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving the room description fails with a 403 (Forbidden) — e.g. because the user's role was downgraded in another session — the TipTapEditor remained open and the save button stayed visible, leaving the UI in an inconsistent edit state.
Changes
RoomTabDescription.vue: In thesave()catch handler, explicitly close the editor (editorOpen.value = false) when the response isHTTP_FORBIDDEN(403), before delegating to the generic error handlerroomCommands.js: Extended thedescriptioncase incheckRoomAuthErrorsto assert that the TipTap editor and save button are absent after a 403 errorCHANGELOG.md: Added entry under[Unreleased] → FixedType
Checklist
Changes
RoomTabDescription.vuesave handlercheckRoomAuthErrorsOther information