Skip to content

Rebuild dashboard / room search#373

Merged
samuelwei merged 73 commits intodevelopfrom
372-add-sorting-option-for-rooms
Nov 7, 2023
Merged

Rebuild dashboard / room search#373
samuelwei merged 73 commits intodevelopfrom
372-add-sorting-option-for-rooms

Conversation

@Sabr1n4W
Copy link
Copy Markdown
Contributor

@Sabr1n4W Sabr1n4W commented Jun 17, 2023

Fixes #372

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Added short description for rooms
  • Added Room favorites
  • Renamed env option OWN_ROOMS_PAGINATION_PAGE_SIZE to ROOM_PAGINATION_PAGE_SIZE (OWN_ROOMS_PAGINATION_PAGE_SIZE deprecated)
  • Refactor user interface for room search and home page

@Sabr1n4W Sabr1n4W added enhancement New feature or request frontend Pull requests that update Javascript code backend Pull requests that update Php code labels Jun 17, 2023
@Sabr1n4W Sabr1n4W self-assigned this Jun 17, 2023
@Sabr1n4W Sabr1n4W linked an issue Jun 17, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@12d514d). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #373   +/-   ##
==========================================
  Coverage           ?   95.10%           
  Complexity         ?     1026           
==========================================
  Files              ?      274           
  Lines              ?     6555           
  Branches           ?      541           
==========================================
  Hits               ?     6234           
  Misses             ?      310           
  Partials           ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei
Copy link
Copy Markdown
Collaborator

#469 Should be merged first

@samuelwei samuelwei changed the title Add Sorting option for rooms Rebuild dashboard / room search Aug 4, 2023
@samuelwei samuelwei changed the base branch from master to develop October 16, 2023 15:31
@Sabr1n4W Sabr1n4W force-pushed the 372-add-sorting-option-for-rooms branch from 266bd71 to 65223e1 Compare October 25, 2023 14:12
Comment thread database/migrations/2023_08_21_090130_rename_own_pagination_setting.php Outdated
Comment thread resources/js/components/Room/RoomComponent.vue Outdated
Comment thread resources/js/components/Room/NewRoomComponent.vue Outdated
Comment thread lang/de/rooms.php Outdated
Comment thread lang/en/rooms.php Outdated
Comment thread routes/api.php Outdated
Comment thread resources/js/components/Room/RoomFavoriteComponent.vue Outdated
Comment thread resources/js/components/Room/RoomFavoriteComponent.vue
Comment thread app/Http/Controllers/api/v1/RoomController.php
Comment thread app/Http/Controllers/api/v1/RoomController.php Outdated
@samuelwei samuelwei merged commit 00918ea into develop Nov 7, 2023
@samuelwei samuelwei deleted the 372-add-sorting-option-for-rooms branch November 7, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Pull requests that update Php code enhancement New feature or request frontend Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebuild dashboard / room search

2 participants