Skip to content

Transfer room ownership#686

Merged
samuelwei merged 32 commits intodevelopfrom
532-transfer-room-ownership
Jan 9, 2024
Merged

Transfer room ownership#686
samuelwei merged 32 commits intodevelopfrom
532-transfer-room-ownership

Conversation

@Sabr1n4W
Copy link
Copy Markdown
Contributor

@Sabr1n4W Sabr1n4W commented Nov 13, 2023 •
edited
Loading

Fixes #532

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • transfer room ownership

@Sabr1n4W Sabr1n4W added enhancement New feature or request frontend Pull requests that update Javascript code backend Pull requests that update Php code labels Nov 13, 2023
@Sabr1n4W Sabr1n4W self-assigned this Nov 13, 2023
@Sabr1n4W Sabr1n4W linked an issue Nov 13, 2023 that may be closed by this pull request
Transfer room ownership #532
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fad2a1f) 95.41% compared to head (b532a8c) 95.41%.
Report is 2 commits behind head on develop.

Files Patch % Lines
app/Http/Controllers/api/v1/RoomController.php 80.00% 4 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #686      +/-   ##
=============================================
- Coverage      95.41%   95.41%   -0.01%     
- Complexity      1032     1045      +13     
=============================================
  Files            279      281       +2     
  Lines           6548     6634      +86     
  Branches         536      541       +5     
=============================================
+ Hits            6248     6330      +82     
- Misses           289      293       +4     
  Partials          11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sabr1n4W
Fix-cs
63ec49b
@Sabr1n4W
Improve backend functioning, disable elements while transferring owne…
c5979dc 
…rship
@Sabr1n4W
Merge branch 'develop' of https://github.com/THM-Health/PILOS into 53…
7462caf 
…2-transfer-room-ownership

# Conflicts:
#	resources/js/views/rooms/View.vue
@Sabr1n4W
Add log messages and start adding backend test
b155f08
@Sabr1n4W
Start adding frontend tests, Fix-cs
a55c0e2
@Sabr1n4W
Improve texts and ui, reload member list
b4f1a04
@Sabr1n4W
improve backend test
1278ee8
@Sabr1n4W
improve frontend tests
6e7190a
@Sabr1n4W
Improve frontend tests
75d5cab
@Sabr1n4W
Improve frontend tests
a6b1407
@Sabr1n4W
Merge branch 'develop' of https://github.com/THM-Health/PILOS into 53…
b06e44d 
…2-transfer-room-ownership
@Sabr1n4W
Improve code, change order of dropdown buttons
a0a9f5a
@Sabr1n4W
Add test for reload on EventBus message
3695cec
@Sabr1n4W
Add test for error at user search
d54ea8a
@Sabr1n4W
Merge branch 'develop' of https://github.com/THM-Health/PILOS into 53…
da6802f 
…2-transfer-room-ownership
@Sabr1n4W
Improve Code
592ef5d
@Sabr1n4W
Merge branch 'develop' of https://github.com/THM-Health/PILOS into 53…
b52464e 
…2-transfer-room-ownership
@Sabr1n4W Sabr1n4W requested a review from samuelwei December 9, 2023 14:42
samuelwei
samuelwei reviewed Dec 21, 2023
View reviewed changes
Comment thread app/Models/User.php Outdated
Comment thread app/Http/Controllers/api/v1/RoomController.php Outdated
Comment thread lang/de/validation.php Outdated
Comment thread resources/js/components/Room/MembersComponent.vue Outdated
Comment thread tests/Frontend/views/rooms/View.spec.js
samuelwei
samuelwei requested changes Dec 21, 2023
View reviewed changes
Comment thread resources/js/components/Room/TransferOwnershipDropdownButton.vue Outdated
@samuelwei samuelwei merged commit d5c7b97 into develop Jan 9, 2024
@samuelwei samuelwei deleted the 532-transfer-room-ownership branch January 9, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelwei samuelwei samuelwei approved these changes

Assignees

@Sabr1n4W Sabr1n4W

Labels

backend Pull requests that update Php code enhancement New feature or request frontend Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transfer room ownership

2 participants

@Sabr1n4W @samuelwei