Skip to content

Remove global attendance recording setting#905

Merged
samuelwei merged 2 commits intodevelopfrom
remove-global-attendance-setting
Mar 6, 2024
Merged

Remove global attendance recording setting#905
samuelwei merged 2 commits intodevelopfrom
remove-global-attendance-setting

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Mar 6, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Remove global attendance recording setting

Other information

Since adding an option to set the attendance recording for each room type, this should be removed to simplify the code.

@samuelwei samuelwei marked this pull request as ready for review March 6, 2024 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (8f34d7b) to head (1aa6f54).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #905      +/-   ##
=============================================
- Coverage      95.66%   95.63%   -0.04%     
+ Complexity      1054     1045       -9     
=============================================
  Files            175      175              
  Lines           3763     3754       -9     
=============================================
- Hits            3600     3590      -10     
- Misses           163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit 5086818 into develop Mar 6, 2024
@samuelwei samuelwei deleted the remove-global-attendance-setting branch June 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant