Skip to content

Refactor load calculation#956

Merged
samuelwei merged 13 commits intodevelopfrom
233-refactor-load-balance-strategy
Mar 27, 2024
Merged

Refactor load calculation#956
samuelwei merged 13 commits intodevelopfrom
233-refactor-load-balance-strategy

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Mar 27, 2024

Fixes #233

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Refactor load calculation to be similar to Scalelite
  • Add plugin system to implement custom load calculation

Other information

Before this PR the load was calculated based on the video streams, voice participants and participants.
After this PR the load is only calculated based on the amount of participants, however during the starting phase of a meeting the number of participants per meetings is set to min. amount. The duration of the starting phase and the min. amount can be changed using BBB_LOAD_MIN_USER_COUNT and BBB_LOAD_MIN_USER_INTERVAL. For meeting with a user limit defined, we use this during the starting phase if it is lower than the global config.

@samuelwei samuelwei linked an issue Mar 27, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.80%. Comparing base (b86c6cf) to head (7edeb7d).

Files Patch % Lines
...p/Plugins/Defaults/ServerLoadCalculationPlugin.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #956   +/-   ##
==========================================
  Coverage      95.80%   95.80%           
- Complexity      1074     1082    +8     
==========================================
  Files            176      178    +2     
  Lines           3815     3842   +27     
==========================================
+ Hits            3655     3681   +26     
- Misses           160      161    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit bb1037e into develop Mar 27, 2024
@samuelwei samuelwei deleted the 233-refactor-load-balance-strategy branch June 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom load balance strategy

1 participant