Skip to content

Refactor time periods and UI for app banner#968

Merged
samuelwei merged 2 commits intodevelopfrom
refactor-time-periods
Apr 2, 2024
Merged

Refactor time periods and UI for app banner#968
samuelwei merged 2 commits intodevelopfrom
refactor-time-periods

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Apr 2, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Cleanup code by using the same time periods for multple app settings
  • Always show all app banner settings to prevent issues with form validation errors

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (3e6fa7f) to head (3001172).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #968   +/-   ##
==========================================
  Coverage      95.80%   95.81%           
- Complexity      1082     1085    +3     
==========================================
  Files            178      178           
  Lines           3842     3845    +3     
==========================================
+ Hits            3681     3684    +3     
  Misses           161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit 6cceecc into develop Apr 2, 2024
@samuelwei samuelwei deleted the refactor-time-periods branch April 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant