Skip to content

Save current room tab on reload#977

Merged
samuelwei merged 3 commits intodevelopfrom
save-room-tab-on-reload
Apr 4, 2024
Merged

Save current room tab on reload#977
samuelwei merged 3 commits intodevelopfrom
save-room-tab-on-reload

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

@samuelwei samuelwei commented Apr 4, 2024

Type (Highlight the corresponding type)

  • Bugfig
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Save current room tab in url to preserve selected tab on reload

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (7648666) to head (0c6c886).

❗ Current head 0c6c886 differs from pull request most recent head 5fc4661. Consider uploading reports for the commit 5fc4661 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #977   +/-   ##
==========================================
  Coverage      95.81%   95.81%           
  Complexity      1085     1085           
==========================================
  Files            178      178           
  Lines           3845     3845           
==========================================
  Hits            3684     3684           
  Misses           161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelwei samuelwei merged commit 9c1d81c into develop Apr 4, 2024
@samuelwei samuelwei deleted the save-room-tab-on-reload branch April 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant