[Feature] Add plugin contract test suite#1652
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 982fc3b94e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ "${{ matrix.info.num_gpus }}" = "0" ]; then | ||
| python "$TEST_PATH" | ||
| else | ||
| python tests/ci/gpu_lock_exec.py --count ${{ matrix.info.num_gpus }} -- python "$TEST_PATH" |
There was a problem hiding this comment.
In .github/workflows/pr-test.yml I checked the fsdp/ckpt matrices and they still include entries like "test_qwen3_4B_fsdp_true_on_policy.py --colocated" and "test_qwen3_4B_ckpt.py --async-save", but the new execute block now wraps "$TEST_PATH" in quotes when calling python (and inside gpu_lock_exec). That turns the script path plus flags into one filename argument, so Python tries to open a non-existent file containing spaces and the CI job fails for any matrix case that appends extra test arguments.
Useful? React with 👍 / 👎.
2 participants
No description provided.