fix: resolve rope_theta from rope_parameters dict in HF config validation#1720
Merged
fix: resolve rope_theta from rope_parameters dict in HF config validation#1720
Conversation
…tion Some models (e.g., GLM-4.6V) store rope_theta inside the rope_parameters dict rather than as a top-level config attribute. The previous code compared against config.rope_theta which returned a stale class default (10000) instead of the actual value (500000 from rope_parameters). This caused validation failures when launching GLM-4.6V training with correct --rotary-base 500000. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models (e.g., GLM-4.6V) store rope_theta inside the rope_parameters dict rather than as a top-level config attribute. The previous code compared against config.rope_theta which returned a stale class default (10000) instead of the actual value (500000 from rope_parameters).
This caused validation failures when launching GLM-4.6V training with correct --rotary-base 500000.