fix: quote nvidia-modelopt requirement in build_conda.sh#1927
Open
zhiminwei551 wants to merge 3 commits into
Open
fix: quote nvidia-modelopt requirement in build_conda.sh#1927zhiminwei551 wants to merge 3 commits into
zhiminwei551 wants to merge 3 commits into
Conversation
Author
|
I noticed that #1554 appears to address the same shell redirection issue. This PR includes a more detailed reproduction and testing notes, but I’m happy to close it if maintainers prefer to keep the older one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Quote the
nvidia-modelopt[torch]>=0.37.0requirement inbuild_conda.sh.Why
Without quotes, the shell parses
>as stdout redirection:As a result, the version constraint is not passed to
pipas intended, and a file named=0.37.0can be created/truncated in the working directory.pipdocumentation recommends quoting requirement specifiers in the shell when using>,<, or environment markers:https://pip.pypa.io/en/stable/reference/requirement-specifiers/#examples
Tested
I also verified the shell parsing behavior with: