[MAINT] Update of package install features and coding contributions#246
[MAINT] Update of package install features and coding contributions#246josephmje merged 16 commits intoTIGRLab:masterfrom
Conversation
|
Hello @josephmje! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-01-08 00:25:03 UTC |
|
This is still a work in progress. I'll send another alert once it's ready for review. |
|
NOTE: |
edickie
left a comment
There was a problem hiding this comment.
My (Erin's) orcid ID: 0000-0003-3028-9864
The rest looks good to me
| author_email = dawn.smith@camh.ca | ||
| maintainer = Dawn Smith | ||
| maintainer_email = dawn.smith@camh.ca | ||
| description = datman is a. |
There was a problem hiding this comment.
Miiiight be good to put a real description here. And as we discussed to replace the author and maintainer emails with our lab gmail
There was a problem hiding this comment.
hahhah thanks for catching that!
There was a problem hiding this comment.
It makes sense to me to replace author_email with tigrlab email and leave maintainer email as dawn's email -- but I missed the discussion, you may have gone over this
No description provided.