Skip to content

[MAINT] Update of package install features and coding contributions#246

Merged
josephmje merged 16 commits intoTIGRLab:masterfrom
josephmje:pypi
Jan 9, 2020
Merged

[MAINT] Update of package install features and coding contributions#246
josephmje merged 16 commits intoTIGRLab:masterfrom
josephmje:pypi

Conversation

@josephmje
Copy link
Copy Markdown
Contributor

No description provided.

@auto-assign auto-assign bot requested review from gabiherman and jskocic December 17, 2019 22:41
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 17, 2019

Hello @josephmje! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 37:13: W503 line break before binary operator
Line 40:80: E501 line too long (82 > 79 characters)
Line 46:80: E501 line too long (84 > 79 characters)
Line 53:80: E501 line too long (88 > 79 characters)
Line 54:80: E501 line too long (81 > 79 characters)
Line 67:80: E501 line too long (80 > 79 characters)
Line 80:80: E501 line too long (81 > 79 characters)

Line 12:80: E501 line too long (82 > 79 characters)

Line 16:1: F401 'datman.config' imported but unused

Line 564:35: W605 invalid escape sequence '\s'
Line 568:35: W605 invalid escape sequence '\s'
Line 572:35: W605 invalid escape sequence '\s'
Line 613:52: W605 invalid escape sequence '\d'
Line 689:33: W605 invalid escape sequence '\d'

Comment last updated at 2020-01-08 00:25:03 UTC

@josephmje
Copy link
Copy Markdown
Contributor Author

This is still a work in progress. I'll send another alert once it's ready for review.

@TIGRLab TIGRLab deleted a comment from the-welcome-bot bot Jan 2, 2020
@TIGRLab TIGRLab deleted a comment from the-welcome-bot bot Jan 2, 2020
@josephmje
Copy link
Copy Markdown
Contributor Author

NOTE: versioneer.py and datman/_version.py are automatically generated by versioneer and don't need to be reviewed.

@josephmje josephmje requested review from DESm1th, edickie and jerdra and removed request for jskocic January 7, 2020 15:59
@josephmje josephmje changed the title [WIP] towards pypi package relase [MAINT] Update of package install features and coding contributions Jan 7, 2020
Copy link
Copy Markdown
Contributor

@edickie edickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My (Erin's) orcid ID: 0000-0003-3028-9864

The rest looks good to me

Comment thread setup.cfg Outdated
author_email = dawn.smith@camh.ca
maintainer = Dawn Smith
maintainer_email = dawn.smith@camh.ca
description = datman is a.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miiiight be good to put a real description here. And as we discussed to replace the author and maintainer emails with our lab gmail

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahhah thanks for catching that!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me to replace author_email with tigrlab email and leave maintainer email as dawn's email -- but I missed the discussion, you may have gone over this

Comment thread .zenodo.json Outdated
@josephmje josephmje merged commit 8560f09 into TIGRLab:master Jan 9, 2020
@josephmje josephmje deleted the pypi branch March 9, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants