Skip to content

[FIX] Modify scanid variable in dm_link.py#248

Merged
josephmje merged 11 commits intoTIGRLab:masterfrom
josephmje:master
Dec 30, 2019
Merged

[FIX] Modify scanid variable in dm_link.py#248
josephmje merged 11 commits intoTIGRLab:masterfrom
josephmje:master

Conversation

@josephmje
Copy link
Copy Markdown
Contributor

@josephmje josephmje commented Dec 30, 2019

Was getting the following error message from dm_link.py:

  File "/archive/code/datman/datman/utils.py", line 1051, in validate_subject_id
    except scanid.ParseException:
UnboundLocalError: local variable 'scanid' referenced before assignment

@auto-assign auto-assign bot requested review from DESm1th and gabiherman December 30, 2019 15:33
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 30, 2019 •
edited
Loading

Hello @josephmje! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-30 15:37:56 UTC

@josephmje josephmje requested review from jerdra and removed request for gabiherman December 30, 2019 15:45
@jerdra
Copy link
Copy Markdown
Contributor

jerdra commented Dec 30, 2019 •
edited
Loading

thanks for catching this! Also surprised that survived for so long lel

@josephmje josephmje merged commit f1d8c6f into TIGRLab:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerdra jerdra jerdra approved these changes

@DESm1th DESm1th Awaiting requested review from DESm1th

+1 more reviewer

@gabiherman gabiherman gabiherman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephmje @pep8speaks @jerdra @gabiherman