[FIX] Python3 conversion bug fixes (Round 2)#252
Merged
DESm1th merged 8 commits intoTIGRLab:masterfrom Dec 31, 2019
Merged
Conversation
defaulting to checking metadata folder for a file
josephmje
reviewed
Dec 31, 2019
| @@ -504,8 +504,8 @@ def get_series_to_add(series, subject): | |||
| t2 = get_split_image(subject, series.series_num, 'T2') | |||
Contributor
There was a problem hiding this comment.
I think we can do away with this bit. dm_xnat_extract.py now takes care of splitting the PDT2 scan into separate files.
Contributor
There was a problem hiding this comment.
might be out of scope for this particular PR, could maybe do a separate one for this specific change?
Contributor
Author
There was a problem hiding this comment.
Ooh good catch. I'll roll that into another one soon (if someone doesnt beat me to it)
Contributor
|
looks good to me! |
jerdra
approved these changes
Dec 31, 2019
josephmje
approved these changes
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.