Skip to content

[FIX] dm_qc_report.py header diff related crashes#255

Merged
DESm1th merged 2 commits intoTIGRLab:masterfrom
DESm1th:master
Jan 9, 2020
Merged

[FIX] dm_qc_report.py header diff related crashes#255
DESm1th merged 2 commits intoTIGRLab:masterfrom
DESm1th:master

Conversation

@DESm1th
Copy link
Copy Markdown
Contributor

@DESm1th DESm1th commented Jan 7, 2020

This fixes two dm_qc_report.py issues:

  1. When the tag and series description are identical the file name is mangled in a way that stops header diffs from being found
  2. When a scan name can't be found in the header diffs the entire report fails to generate

@auto-assign auto-assign bot requested review from gabiherman and jskocic January 7, 2020 17:37
gabiherman
gabiherman approved these changes Jan 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gabiherman gabiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@DESm1th DESm1th requested review from jerdra and josephmje January 9, 2020 15:40
@DESm1th DESm1th merged commit 2c1117c into TIGRLab:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephmje josephmje josephmje approved these changes

@jskocic jskocic Awaiting requested review from jskocic

@jerdra jerdra Awaiting requested review from jerdra

+1 more reviewer

@gabiherman gabiherman gabiherman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DESm1th @josephmje @gabiherman