Merged
Conversation
DESm1th
requested review from
gabiherman and
jskocic
and removed request for
josephmje
gabiherman
reviewed
Jan 20, 2020
|
|
||
| if not experiment: | ||
| logger.error("No matching experiments for subject {}. " | ||
| logger.error("Redcap record may be misnamed - no matching " |
Contributor
There was a problem hiding this comment.
Do you think this might be more informative if it says REDCap or XNAT might be misnamed, since it could be either?
Contributor
Author
There was a problem hiding this comment.
Good point! Let me fix that
gabiherman
approved these changes
Jan 21, 2020
jerdra
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No one seems to care about the multiple UUIDs so I've made that quieter, and I've allowed dm_blacklist_rm to delete blacklisted scans even if the entire session hasn't finished being signed off.