[FIX/MAINT] - Only deploy on pypi when commits/PRs are made to the release branch#262
Merged
DESm1th merged 3 commits intoTIGRLab:masterfrom Feb 21, 2020
Merged
[FIX/MAINT] - Only deploy on pypi when commits/PRs are made to the release branch#262DESm1th merged 3 commits intoTIGRLab:masterfrom
DESm1th merged 3 commits intoTIGRLab:masterfrom
Conversation
josephmje
reviewed
Feb 7, 2020
Contributor
josephmje
left a comment
josephmje
left a comment
There was a problem hiding this comment.
I think we want test_deploy_pypi to run at every PR because if our package doesn't build, there could be something very wrong.
Also, we don't currently have a release branch. I think deployable is fine to run on the master branch but only for tagged releases. For some reason, that tags regex isn't getting picked up? 😕
josephmje
reviewed
Feb 7, 2020
josephmje
reviewed
Feb 7, 2020
josephmje
reviewed
Feb 7, 2020
Contributor
josephmje
left a comment
josephmje
left a comment
There was a problem hiding this comment.
Do you think these suggestions might work?
Co-Authored-By: Michael Joseph <josephmje.22@gmail.com>
Co-Authored-By: Michael Joseph <josephmje.22@gmail.com>
josephmje
approved these changes
Feb 7, 2020
DESm1th
approved these changes
Feb 12, 2020
Contributor
DESm1th
left a comment
DESm1th
left a comment
There was a problem hiding this comment.
Ahh sorry! Forgot about this. Everything looks fine to me! Thanks Jer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Master will be our in-house production branch which is always being tweaked, we want to reserve deployment for milestones/major bug fixes.
Any commit/PR pushed to the branch release will be deployed to pypi.